2013.09.01. 19:04 keltezéssel, Dirk Neukirchen írta: > On 01.09.2013 16:01, Gabor Juhos wrote: >> 2013.08.28. 13:48 keltezéssel, Aidan Kissane írta: >>> This patch adds OpenWRT support for the Netgear WNR2200 (N300) >>> wireless router with USB. >>> >>> Technical details of this router can be found at >>> http://www.netgear.com/home/products/wirelessrouters/work-and-play/WNR2200.aspx >>> and http://wikidevi.com/wiki/Netgear_WNR2200 >>> >>> The patch includes a new ar71xx/files/arch/mips/ath79/mach-wnr2200.c >>> file and corresponding updates to the base-files/etc/diag.sh, >>> base-files/etc/uci-defaults/02_network, >>> ar71xx/base-files/lib/ar71xx.sh, ar71xx/config-3.10, >>> ar71xx/generic/profiles/netgear.mk and ar71xx/image/Makefile files. >>> >>> >>> Signed-off-by: Aidan Kissane <aidankissane at googlemail.com> >> >> Sorry, the patch is still corrupted like the previous version. >> >> -Gabor >> _______________________________________________ >> openwrt-devel mailing list >> openwrt-devel@lists.openwrt.org >> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel >> > > Not original submitter but I had some problems with badly formatting too - > its just difficult to fix with standard mail clients like thunderbird > because of those hidden options > TB: > http://kb.mozillazine.org/Plain_text_e-mail_%28Thunderbird%29#Completely_Plain_Email > > nevertheless the following patch applies
Indeed, it does apply now. > (dunno if next is necessary for reformatting) Yes, it is necessary. The coding style of the mach-wnr2200.c file is horrible: > [juhosg@mag2 openwrt (wnr2200)]$ ./scripts/checkpatch.pl -f > target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c --terse > target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c:24: ERROR: do not > use C99 // comments > target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c:41: ERROR: do not > use C99 // comments > target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c:42: ERROR: do not > use C99 // comments > <...> > target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c:164: ERROR: code > indent should use tabs where possible > target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c:164: WARNING: > please, no spaces at the start of a line > target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c:166: ERROR: code > indent should use tabs where possible > target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c:166: WARNING: > please, no spaces at the start of a line > total: 96 errors, 72 warnings, 170 lines checked > [juhosg@mag2 openwrt (wnr2200)]$ Additionally, a board specific patch is missing from 'target/linux/ar71xx/patches-3.10'. Thanks, Gabor _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
