On Mon, Dec 26, 2016 at 12:04 AM, Nadav Har'El <n...@scylladb.com> wrote: > Commit e270cf9c (more than two years ago) was well-intentioned, but > introduced a new bug: we no longer wait for the background programs > to finish before stopping httpserver. So for example if the command > line is something like > > /cli/cli.so & finish_quickly.so > > And finish_quickly.so finishes quickly, we do not wait for cli.so to > finish before killing httpserver. > > One user discovered that because of that, the image created by > "./scripts/build image=java-example,cli" runs the short-lived java-example > but then the CLI doesn't work: It can't run any commands because the > httpserver it relies on is already dead. > > So this patch partially reverts e270cf9c... We keep the "app registry" > introduced there, but we still have a separate list of background apps > started in the command line - and wait for them to finish before asking > httpserver to exit. > > Signed-off-by: Nadav Har'El <n...@scylladb.com>
Looks good to me. -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to osv-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
