Branch: refs/heads/blead
Home: https://github.com/Perl/perl5
Commit: 743293ba242cb0021cda3c85364f93cc89c3ae3e
https://github.com/Perl/perl5/commit/743293ba242cb0021cda3c85364f93cc89c3ae3e
Author: Paul "LeoNerd" Evans <leon...@leonerd.org.uk>
Date: 2024-03-19 (Tue, 19 Mar 2024)
Changed paths:
M pad.c
M pod/perldiag.pod
M t/lib/warnings/builtin
M t/lib/warnings/pad
Log Message:
-----------
Revert "Warn about shadowing names when importing a lexical sub whose name
matches a package one"
This partly reverts commit 31273fbcec76b8eef204e7d7c8dde2b78d0e0ce5
which was committed in https://github.com/Perl/perl5/pull/21915
It has been found that this warning creates too many warnings from
otherwise-harmless situations, and additionally acts inconsistently with
other behaviours such as lexical variables. In any case it only warns in
the less likely package-then-lexical order, and not in the more likely
lexical-then-package order which was the original intent of the
discussion leading up to its invention.
We decided to remove it
https://github.com/Perl/perl5/pull/21915#issuecomment-1998021478
I have left the changes to t/op/attrproto.t and t/op/lexsub.t in place
because those were just renames for something that made debugging the
tests confusing. They're not directly related to this warning, so should
remain.
To unsubscribe from these emails, change your notification settings at
https://github.com/Perl/perl5/settings/notifications
