On Tue Jun 23 02:43:41 2015, [email protected] wrote: > On Mon Feb 16 22:11:44 2015, coke wrote: > > On Fri Mar 29 11:23:03 2013, coke wrote: > > > On Fri Aug 31 12:10:54 2012, moritz wrote: > > > > In nom, prefix and --> return type constraints weren't > > > > implemented > > > > for > > > > quite some time, which made the tests pass even though they > > > > shouldn't. > > > > > > Currently failure mode of tests: > > > > > > 14:21 < [Coke]> r: our Int sub foo { fail('a') }; say foo() ~~ > > > Failure > > > 14:21 <+p6eval> rakudo 897636: OUTPUT«a in method sink at > > > src/gen/CORE.setting:10630 in method BUILDALL at > > > src/gen/CORE.setting:801 in method bless at > > > src/gen/CORE.setting:743 in method new at > > > src/gen/CORE.setting:728 in method new at > > > src/gen/CORE.setting:726 in sub foo at > > > /tmp/Uu3wdrYiKc:1… > > > 14:21 < moritz> sink bug > > > 14:21 < moritz> *sadface* > > > > > > > This is now failing in a way very similar to the original bug report: > > > > $ ./perl6-m -e 'our Int sub foo() { return fail() }; foo()' > > Type check failed for return value; expected 'Int' but got 'Failure' > > in any return_error at src/vm/moar/Perl6/Ops.nqp:649 > > in sub foo at -e:1 > > in block <unit> at -e:1 > > Failure has been special-cased in p6typecheckrv to always match type > checks in Rakudo commit f1fa6445d8c7b46010443dcabed709aef150b78f. As > mentioned in the commit message, jnthn++ has some concerns about > inlineability of subs, but I can't see what to change how exactly. > Roast commits f1fa6445d8c7b46010443dcabed709aef150b78f corrects a few > tests that expect X::TypeCheck::Return to check for the now correct > X::Numeric::DivideByZero instead, while > f6461b3eca27c1a873b545ee23a04a327094c73 unfudges the existing tests in > S04-exceptions/fail.t.
I'm closing this ticket as 'resolved'.
