# New Ticket Created by James Keenan
# Please include the string: [perl #44561]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=44561 >
---
osname= linux
osvers= 2.6.18.3
arch= i486-linux-gnu-thread-multi
cc= cc
---
Flags:
category=core
severity=low
ack=no
---
Where we can use the qr// operator rather than a string 'eval', let's do
so. Here is a patch for Parrot::Vtable. It should have no impact on
performance but makes coverage by tests clearer.
I will apply to trunk in about three days unless there is serious
objection.
Thank you very much.
kid51
2c2
< # $Id: Vtable.pm 20228 2007-07-26 23:39:29Z tewk $
---
> # $Id: Vtable.pm 20321 2007-07-29 18:46:42Z jkeenan $
40,44c40,43
<
< my $comp_re = eval "qr/$re/";
<
< if ($@) { return "(?:$re)"; }
< else { return $comp_re; }
---
> my $comp_re = qr/$re/;
> return (defined $comp_re)
> ? $comp_re
> : "(?:$re)";
---
Summary of my parrot 0.4.14 (r20605) configuration:
configdate='Sat Aug 11 13:24:05 2007 GMT'
Platform:
osname=linux, archname=i686-linux
jitcapable=1, jitarchname=i386-linux,
jitosname=LINUX, jitcpuarch=i386
execcapable=1
perl=/usr/local/bin/perl
Compiler:
cc='cc', ccflags=' -pipe -I/usr/local/include -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DHASATTRIBUTE_CONST
-DHASATTRIBUTE_DEPRECATED -DHASATTRIBUTE_MALLOC -DHASATTRIBUTE_NORETURN
-DHASATTRIBUTE_PURE -DHASATTRIBUTE_UNUSED -DHASATTRIBUTE_WARN_UNUSED_RESULT',
Linker and Libraries:
ld='cc', ldflags=' -L/usr/local/lib',
cc_ldflags='',
libs='-lnsl -ldl -lm -lcrypt -lutil -lpthread -lrt'
Dynamic Linking:
share_ext='.so', ld_share_flags='-shared -L/usr/local/lib -fPIC',
load_ext='.so', ld_load_flags='-shared -L/usr/local/lib -fPIC'
Types:
iv=long, intvalsize=4, intsize=4, opcode_t=long, opcode_t_size=4,
ptrsize=4, ptr_alignment=1 byteorder=1234,
nv=double, numvalsize=8, doublesize=8
---
Environment:
HOME =/home/jimk
LANG (unset)
LANGUAGE (unset)
LD_LIBRARY_PATH (unset)
LOGDIR (unset)
PATH
=/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/games:/usr/local/mysql/bin:/home/jimk/bin:/home/jimk/bin/perl
SHELL =/bin/bash
