On Saturday 22 December 2007 18:07:27 James Keenan wrote:
Nearly everything applied and ran fine for me, but I have one question:
> Index: t/configure/115-auto_warnings-06.t
> ===================================================================
> --- t/configure/115-auto_warnings-06.t (revision 0)
> +++ t/configure/115-auto_warnings-06.t (revision 0)
> +#{
> +# my $warning = q{-Wphony_warning};
> +# my $stdout;
> +# capture(
> +# sub { auto::warnings::_set_warning($conf, $warning, 1, 1); },
> +# \$stdout,
> +# );
> +# ok(! $conf->data->get($warning),
> +# "Got expected setting for warning");
> +# like($stdout, qr/exit code:\s+1/, "Got expected verbose output");
> +#}
Is it necessary to check in commented code? I'm all for deleting it in
general if it's commented out. We can always restore it from a previous
revision if it's necessary.
-- c