On Tuesday 29 April 2008 20:28:25 Andy Dougherty wrote:
> When compilation of a file in src/dynpmc/ fails, the build continues
> anyway -- there was an existing "die" command, but it could never actually
> be triggered. This patch actually looks at the return value and dies if
> the compilation fails. (Otherwise, the error gets buried and is easy to
> miss.)
>
> --- parrot-svn/config/gen/makefiles/dynpmc_pl.in Mon Apr 28 12:31:26 2008
> +++ parrot-andy/config/gen/makefiles/dynpmc_pl.in Tue Apr 29 11:28:15 2008
> @@ -270,12 +270,10 @@
>
> $dest_stem ||= $src_stem;
> if (needs_build("$dest_stem$O", "$src_stem.c")) {
> - return run(compile_cmd("$dest_stem$O", "$src_stem.c"))
> + run(compile_cmd("$dest_stem$O", "$src_stem.c"))
> or die "compile $src_stem.c failed ($?)\n";
> }
> - else {
> - return 1;
> - }
> + return 1;
> }
>
> sub partial_link {
Thanks, applied as r27247.
-- c
