On Wednesday 28 May 2008 18:15:32 James Keenan via RT wrote:
> Yes. That worked. Thanks for the suggestion. Please see revised patch
> attached.
All tests pass for me, so +1 here. I say commit away.
I do have one more question though:
> +{
> + my $tdir = tempdir();
> + foreach my $g (keys %samples) {
> + open my $IN, '>', qq{$tdir/$samples{$g}{file}}
> + or die "Unable to open $samples{$g}{file} for writing";
> + print $IN $samples{$g}{text};
> + close $IN or die "Unable to close $samples{$g}{file} after
> writing"; + }
What's with the mix of qq{} and ""? I'm sure this q{} and qq{} silliness is
from one of the 3/256 Perl Best Practices where Damian revealed himself as a
fallible mortal, but why the inconsistency? (qq{} reveals itself as ugly in
its use above.)
-- c
