To extend this to support PostgreSQL 8.4 CSV format log files, I think we need 
to do a couple of things:

First, the pg_logdir_ls function from the admin pack would need to be updated 
to look for .log or .csv files, not just .log.

Then we would need to recognize that we are reading a file with extension .csv, 
and handle it the way I do in the patch for GPDB (rather than being based on 
GetIsGreenplum()).

Finally, we'd just need to figure out what each field being logged by 
PostgreSQL 8.4 is, and update the code so that it understands that as well as 
the GPDB fields.

> -----Original Message-----
> From: pgadmin-hackers-ow...@postgresql.org [mailto:pgadmin-hackers-
> ow...@postgresql.org] On Behalf Of Chuck McDevitt
> Sent: Thursday, June 04, 2009 7:40 PM
> To: pgadmin-hackers@postgresql.org
> Subject: [pgadmin-hackers] New patch for bugs in GPDB csv format log
> handling
> 
> This patch fixes many problems in the handling of GPDB CSV format logs
> for the frmStatus display.
> 
> It's also a useful start for supporting PostgreSQL 8.4 CSV format logs.


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Reply via email to