Thanks, applied. On Fri, Jun 9, 2017 at 10:18 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote:
> Hi, > > Please find the attached updated patch. > > Fixed the PostGIS Datatypes in SQL tab, Create / Update dialogues for > Table, Column, Foreign Table and Type node. > > Regarding the review comment given by Dave (Also, I there should be a > space between the , and value in the_geom geometry(MultiPolygon,3310).), > won't be fixed as this format is returned by format_type() function itself. > > As per the conversation with Dave, I have logged RM #2473 > <https://redmine.postgresql.org/issues/2473> to add support for PostGIS > Datatypes. > > Thanks, > Khushboo > > On Tue, Jun 6, 2017 at 6:49 PM, Dave Page <dp...@pgadmin.org> wrote: > >> >> >> On Tue, Jun 6, 2017 at 2:15 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On 6 Jun 2017 18:36, "Dave Page" <dp...@pgadmin.org> wrote: >>> >>> >>> >>> On Tue, Jun 6, 2017 at 1:23 PM, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> >>>> >>>> >>>> On 6 Jun 2017 17:42, "Dave Page" <dp...@pgadmin.org> wrote: >>>> >>>> Hi >>>> >>>> The table and column dialogues seem to have related problems. For >>>> example, the table dialogue shows the length of the geometry field in the >>>> test case as 847,380, whilst the column dialogue shows no length at all. >>>> >>>> What should be there in length and precision fields in this case? >>>> >>> >>> I have no idea :-). What did pgAdmin 3 do here? I assume there's some >>> way to decode the typmod into the desired values, and map them back to >>> appropriate SQL. >>> >>> I will try to figure out the way. >>> pgAdmin 3 has the same issue, so I have asked for the suggestion. >>> >> >> Oh, OK - thanks. Maybe we need to reuse the length and precision fields >> for these types. That is, I believe, essentially how PostGIS passes extra >> info to the column definitions. >> >> >>> >>> >>>> Also, I there should be a space between the , and value in the_geom >>>> geometry(MultiPolygon,3310). >>>> >>>> Thanks. >>>> >>>> On Mon, Jun 5, 2017 at 8:32 AM, Khushboo Vashi < >>>> khushboo.va...@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Fixed PostGIS datatype on SQL tab for Table, column, Foreign Table and >>>>> Type node. >>>>> >>>>> Please find the attached updated patch. >>>>> >>>>> >>>>> Thanks, >>>>> Khushboo >>>>> >>>>> On Thu, Jun 1, 2017 at 6:36 PM, Murtuza Zabuawala < >>>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>>> >>>>>> >>>>>> On Thu, Jun 1, 2017 at 5:27 PM, Khushboo Vashi < >>>>>> khushboo.va...@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> >>>>>>> On Thu, Jun 1, 2017 at 4:57 PM, Murtuza Zabuawala < >>>>>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Khushboo, >>>>>>>> >>>>>>>> Please include Type node and Foreign Table node in your fix :-) >>>>>>>> >>>>>>>> I don't think Type node requires this change. >>>>>>> >>>>>>> Yes, It do require because user can create composite type from >>>>>> existing types. >>>>>> [image: Inline image 1] >>>>>> >>>>>>> Foreign table changes added in the attached updated patch. >>>>>>> >>>>>>>> -- >>>>>>>> >>>>>>> Thanks Murtuza for pointing this out. >>>>> >>>>> >>>>>> Regards, >>>>>>>> Murtuza Zabuawala >>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> On Thu, Jun 1, 2017 at 3:23 PM, Khushboo Vashi < >>>>>>>> khushboo.va...@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Please find the attached patch to fix RM #2324 : PostGIS datatypes >>>>>>>>> not showing up properly on SQL tab. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Khushboo >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>>> To make changes to your subscription: >>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
