pg_upgrade: Fix detection of invalid logical replication slots. Commit 7a1f0f8747a optimized the slot verification query but overlooked cases where all logical replication slots are already invalidated. In this scenario, the CTE returns no rows, causing the main query (which used a cross join) to return an empty result even when invalid slots exist.
This commit fixes this by using a LEFT JOIN with the CTE, ensuring that slots are properly reported even if the CTE returns no rows. Author: Lakshmi N <[email protected]> Reviewed-by: Shveta Malik <[email protected]> Reviewed-by: Chao Li <[email protected]> Discussion: https://postgr.es/m/ca+3i_m8et6j8_cbhkyykv-sxcxbmaxpvskptjdvq+mftpt-...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e471dc59121932d669d69d0683c71d5df3b527e3 Modified Files -------------- src/bin/pg_upgrade/info.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
