On Wed, Dec 3, 2014 at 9:21 PM, Peter Geoghegan <[email protected]> wrote: > On Tue, Dec 2, 2014 at 1:11 PM, Robert Haas <[email protected]> wrote: >> Basically, the case in which I think it's helpful to issue a >> suggestion here is when the user has used the table name rather than >> the alias name. I wonder if it's worth checking for that case >> specifically, in lieu of what you've done here, and issuing a totally >> different hint in that case ("HINT: You must refer to this as column >> as "prime_minister.id" rather than "cameron.id"). > > Well, if an alias is used, and you refer to an attribute using a > non-alias name (i.e. the original table name), then you'll already get > an error suggesting that the alias be used instead -- of course, > that's nothing new. It doesn't matter to the existing hinting > mechanism if the attribute name is otherwise wrong. Once you fix the > code to use the alias suggested, you'll then get this new > Levenshtein-based hint.
In that case, I think I favor giving no hint at all when the RTE name is specified but doesn't match exactly. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
