Tom Lane <[email protected]> writes: > Andreas Seltenreich <[email protected]> writes: >> The scary one is due to an integer overflow the attached patch also >> fixes. > > s/int/Size/ doesn't fix anything on 32-bit machines.
Well, it changes the signedness of the computation on 32-bit, and in combination with the fact that "len" is always smaller than 2^32, but may exceed 2^31-1, the change avoids the dependency on the undefined behavior of signed integer overflows in C on 32-bit as well. But I admit that this might be a rather academic point... Anyway, my motivation for the patch was the improved error reporting. Is the drive-by type change a problem here? regards, Andreas -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
