Hi all,

In pg_regress.c, there is the following code:
static void
stop_postmaster(void)
{
        if (postmaster_running)
        {
                /* We use pg_ctl to issue the kill and wait for stop */
                char            buf[MAXPGPATH * 2];
                int                     r;

                /* On Windows, system() seems not to force fflush, so... */
                fflush(stdout);
                fflush(stderr);

                snprintf(buf, sizeof(buf),
                                 "\"%s%spg_ctl\" stop -D \"%s/data\"
-w -s -m fast",
                                 bindir ? bindir : "",
                                 bindir ? "/" : "",
                                 temp_instance);

Except if I am missing something, the comment mentions that we should
wait for the stop but there is no -w switch in the command of pg_ctl.
Doesn't the patch attached make sense?
Regards
-- 
Michael
diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
index a267894..0a05f98 100644
--- a/src/test/regress/pg_regress.c
+++ b/src/test/regress/pg_regress.c
@@ -265,7 +265,7 @@ stop_postmaster(void)
 		fflush(stderr);
 
 		snprintf(buf, sizeof(buf),
-				 "\"%s%spg_ctl\" stop -D \"%s/data\" -s -m fast",
+				 "\"%s%spg_ctl\" stop -D \"%s/data\" -w -s -m fast",
 				 bindir ? bindir : "",
 				 bindir ? "/" : "",
 				 temp_instance);
-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to