On Wed, Dec 16, 2015 at 3:33 AM, Kyotaro HORIGUCHI <[email protected]> wrote: > Hello, I think I found a typo in a comment of syncrep.c. > >> * acknowledge the commit nor raise ERROR or FATAL. The latter would >> - * lead the client to believe that that the transaction aborted, which >> * is not true: it's already committed locally. The former is no good > > The 'that' looks duplicate.
Agreed. > And it might be better to put a > be-verb before the 'aborted'. > >> + * lead the client to believe that the transaction is aborted, which No, that's correct the way it is. What you're proposing wouldn't exactly be wrong, but it's a little less clear and direct. Committed the part of your patch that removes the extra "that". -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
