On Thu, Jun 1, 2017 at 3:36 AM, Michael Paquier <[email protected]> wrote: > On Wed, May 31, 2017 at 7:18 PM, Craig Ringer <[email protected]> wrote: >> Note that you can achieve the same effect w/o patching >> PostgresNode.pm, albeit in a somewhat ugly manner, by re-blessing the >> returned object. >> >> sub get_new_mywhatever_node { >> my $self = PostgresNode::get_new_node($name); >> $self = bless $self, 'MyWhateverNode'; >> return $self; >> } >> >> so this would be cosmetically nice, but far from functionally vital. > > + $pgnclass = 'PostgresNode' unless defined $pgnclass; > I'd rather leave any code of this kind for the module maintainers, > there is no actual reason to complicate PostgresNode.pm with code > that's not directly useful for what is in-core.
Craig's proposal is a standard Perl idiom, though. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
