On Wed, 20 Mar 2024 at 12:49, Peter Eisentraut <pe...@eisentraut.org> wrote: > > On 19.03.24 17:13, Peter Eisentraut wrote: > > On 11.03.24 21:52, Matthias van de Meent wrote: > >>> * v7-0003-gen_node_support.pl-Mark-location-fields-as-type-.patch > >>> > >>> This looks sensible, but maybe making Location a global type is a bit > >>> much? Maybe something more specific like ParseLocation, or ParseLoc, to > >>> keep it under 12 characters. > >> I've gone with ParseLoc in the attached v8 patchset. > > > > I have committed this one. > > Next, I was looking at > v8-0003-pg_node_tree-Don-t-store-query-text-locations-in-.patch.
[...] > So anyway, my idea was that we should turn this around and make > nodeToString() always drop location information, and instead add > nodeToStringWithLocations() for the few debugging uses. And this would > also be nice because then it matches exactly with the existing > stringToNodeWithLocations(). That seems reasonable, yes. -Matthias
