On Thu, Oct 29, 2020 at 2:26 PM Daniel Westermann (DWE) <daniel.westerm...@dbi-services.com> wrote: > > On 27/10/2020 15:36, vignesh C wrote: > >> Attached v9 patches have the fixes for the above comments. > > >I did some testing: > > I did some testing as well and have a cosmetic remark: > > postgres=# copy t1 from '/var/tmp/aa.txt' with (parallel 1000000000); > ERROR: value 1000000000 out of bounds for option "parallel" > DETAIL: Valid values are between "1" and "1024". > postgres=# copy t1 from '/var/tmp/aa.txt' with (parallel 100000000000); > ERROR: parallel requires an integer value > postgres=# > > Wouldn't it make more sense to only have one error message? The first one > seems to be the better message. >
I had seen similar behavior in other places too: postgres=# vacuum (parallel 1000000000) t1; ERROR: parallel vacuum degree must be between 0 and 1024 LINE 1: vacuum (parallel 1000000000) t1; ^ postgres=# vacuum (parallel 100000000000) t1; ERROR: parallel requires an integer value I'm not sure if we should fix this. Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com