On 10/05/17 22:17, Dmitry Dolgov wrote: >> On 4 May 2017 at 20:05, Magnus Hagander <mag...@hagander.net > <mailto:mag...@hagander.net>> wrote: >> >> PFA a patch that adds a new function, pg_move_replication_slot, that > makes it >> possible to move the location of a replication slot without actually >> consuming all the WAL on it. > > Just a few questions just a few questions out of curiosity: > > * does it make sense to create a few tests for this function in > `contrib/test_decoding` (as shown in attachment)? >
As Craig said this will not work correctly for logical slots so it should throw error on those at the moment (at least until we write something that works, but that's far more complex than this patch). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
