a.akent...@postgrespro.ru wrote: > This function has two calls: > check_bin_dir(&old_cluster); > check_bin_dir(&new_cluster); > > I'd like to substitute these last two lines with this: > get_bin_version(cluster);
Odd indeed. One would think that if a cluster variable is passed as parameter, the global vars should not be used. +1 for fixing it, and your proposal sounds as good as any. > Doing it would simplify the patch I'm writing, but I'm worried I might break > something that's been there for a long time and has been working fine. I think odd coding this was introduced recently because of the pg_resetxlog -> pg_resetwal renaming. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
