On 21 March 2012 03:19, Guillermo Polito <guillermopol...@gmail.com> wrote:
> Because this:
>
> SmalltakImage>>openLog
>     "This is a _private_ method,
>     Because it really belongs to logging facility,
>     we should delegate to it at some point "
>
>     ^ ( FileStream fileNamed: Smalltalk tools debugger logFileName )
>         wantsLineEndConversion: true;
>         setToEnd;
>         yourself
>
>
> Is ugly :)

yes.
now compare this with older code where 'PharoDebug.log' string were
directly used in multiple places.

I think it should be something like:

^ self tools log open

then we just register a tool - #log.. which responsible for logging..
anywhere it wants (to file/syslog whatever).


>
> Guille



-- 
Best regards,
Igor Stasenko.

Reply via email to