Edit report at https://bugs.php.net/bug.php?id=64396&edit=1

 ID:                 64396
 Comment by:         mattfic...@php.net
 Reported by:        mattfic...@php.net
 Summary:            tests/basic/req60524.phpt should not be run on
                     Windows
 Status:             Feedback
 Type:               Bug
 Package:            *Directory/Filesystem functions
 Operating System:   Windows
 PHP Version:        5.5.0alpha5
 Assigned To:        mattficken
 Block user comment: N
 Private report:     N

 New Comment:

Yes I committed it, but forgot to close this bug report.


Previous Comments:
------------------------------------------------------------------------
[2013-09-01 01:16:18] paj...@php.net

Matt? Did you apply it?

------------------------------------------------------------------------
[2013-03-22 06:30:41] paj...@php.net

Please duplicate the test and commit it :)

------------------------------------------------------------------------
[2013-03-21 22:55:39] mattfic...@php.net

The point of this test is to test the new sys_temp_dir directive to make sure 
that the directive value is returned by sys_get_temp_dir.    The point of the 
directive is to enable using different INI files to get sys_get_temp_dir to 
return different temp dirs (for virtual hosts).

Directives have to be set in the INI section. The PHPT format doesn't provide a 
way to have different INI sections for Windows or *nix.

Therefore there needs to be a separate -win32 fork for this test, which is what 
the original patch does.

------------------------------------------------------------------------
[2013-03-09 01:07:45] paj...@php.net

Thanks for the patch!

I would modify the test to compare the string result instead and output OK when 
it 
matches. Doing so will avoid to create a windows only version of this test 
(which 
basically test the ini setting). Feel free to commit it once you are done :)

------------------------------------------------------------------------
[2013-03-08 23:42:38] mattfic...@php.net

Description:
------------
This is a new test of sys_get_temp_dir() but won't work on Windows.

I have attached a patch that patches this test and creates a win32 equivalent 
test.


Expected result:
----------------
/path/to/temp/dir

Actual result:
--------------
C:\Users\matt\AppData\Local\Temp


------------------------------------------------------------------------



-- 
Edit this bug report at https://bugs.php.net/bug.php?id=64396&edit=1

Reply via email to