ervin added a comment.
Just a minor thing, otherwise LGTM, I'll let Kai give the last stamp of approval. INLINE COMMENTS > gtkconfig.cpp:113 > + setFont(); > + setFont(); > + setIconTheme(KIconLoader::Group::Desktop); Are you sure you want to call setFont() twice here? That looks surprising. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24743 To: gikari, #plasma, #vdg Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart