ervin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ModuleView.cpp:427
> Not saying this is wrong, but can you explain this change?
> 
> In https://phabricator.kde.org/D25072
> 
> we do setEnabled((buttons & Default) && !defaulted) rather than changing 
> visibility, presumably it's there to make sure buttons don't move as you 
> navigate between modules.

It feels kind of wrong indeed. Better align that behavior with the one from 
kcmshell. I'll make a reworked patch in that direction.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D25074

To: ervin, #plasma, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to