ervin added inline comments.

INLINE COMMENTS

> crossi wrote in main.qml:33
> I agree it's a bit tricky, we have a kind of enum choice written as a binary 
> representation in the config file.
> 
> Will try to work it with a QML enum to make it less confusing.

Or... but that's more work and I'd say it should come in another patch on top 
of that one. We migrate the config file to use an enum all the way. This 
boolean trap exists in the config after all.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25290

To: crossi, #plasma, ervin, bport, mart, davidedmundson
Cc: broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to