bshah updated this revision to Diff 80832. bshah marked 15 inline comments as done. bshah added a comment.
address various comments - adhere to interface name when registering watcher - remove unused code - use qdbusservicewatcher - add valid property REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28509?vs=80391&id=80832 BRANCH bshah/notification-watcher REVISION DETAIL https://phabricator.kde.org/D28509 AFFECTED FILES libnotificationmanager/CMakeLists.txt libnotificationmanager/abstractnotificationsmodel.cpp libnotificationmanager/abstractnotificationsmodel.h libnotificationmanager/abstractnotificationsmodel_p.h libnotificationmanager/dbus/org.kde.notificationmanager.xml libnotificationmanager/declarative/notificationmanagerplugin.cpp libnotificationmanager/notification.cpp libnotificationmanager/notification.h libnotificationmanager/notification_p.h libnotificationmanager/notificationsmodel.cpp libnotificationmanager/notificationsmodel.h libnotificationmanager/server_p.cpp libnotificationmanager/server_p.h libnotificationmanager/watchednotificationsmodel.cpp libnotificationmanager/watchednotificationsmodel.h To: bshah, #plasma, broulik, davidedmundson Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
