----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107869/#review63399 -----------------------------------------------------------
The coding style in the entire review is off. File Attachment: the patch - 0002-Add-a-real-konquerorsessions-plugin_1.patch <https://git.reviewboard.kde.org//r/107869/#fcomment230> I don't really understand the whole "kate" comment. - Vishesh Handa On Dec. 23, 2012, 12:27 p.m., Jekyll Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/107869/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2012, 12:27 p.m.) > > > Review request for Plasma. > > > Bugs: 188494 > http://bugs.kde.org/show_bug.cgi?id=188494 > > > Repository: kdeplasma-addons > > > Description > ------- > > This is a follow-up of https://git.reviewboard.kde.org/r/107868/ . > > The code is based upon the old and unreal konquerorsessions plugin, with > minimal modification (since I'm not familiar with krunner plugins) to make it > work in the way as its name implies. > > The patch can't be uploaded as diff, since it depends upon the patch in > https://git.reviewboard.kde.org/r/107868/ and that one has not be committed. > See the attached file below. > > > Diffs > ----- > > > Diff: https://git.reviewboard.kde.org/r/107869/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > the patch > > https://git.reviewboard.kde.org/media/uploaded/files/2012/12/23/0002-Add-a-real-konquerorsessions-plugin_1.patch > > > Thanks, > > Jekyll Wu > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
