-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126466/
-----------------------------------------------------------

(Updated Dec. 22, 2015, 4:56 p.m.)


Review request for Plasma and David Edmundson.


Changes
-------

Move I/O out of the rendering thread again. Do pixmap loading after props are 
done in polish processing, render when needed.


Bugs: 345545
    http://bugs.kde.org/show_bug.cgi?id=345545


Repository: plasma-framework


Description
-------

This timer seems to exist purely to delay loading the pixmap for the purpose of 
"hey, maybe it will work later ..." when it's not actually needed thanks to 
QQmlParserStatus. Dropping it brings speed up to par with QIconItem and fixes 
various icon flicker around Plasma, in particular in the Task Manager: When 
swapping out a launcher delegate for a task delegate, or when swapping out 
delegates during virtual desktop switches.


Diffs (updated)
-----

  src/declarativeimports/core/iconitem.h 3abef40 
  src/declarativeimports/core/iconitem.cpp bada940 

Diff: https://git.reviewboard.kde.org/r/126466/diff/


Testing
-------


Thanks,

Eike Hein

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to