> On Jan. 27, 2016, 6:22 p.m., Thomas Lübking wrote: > > effects/blur/blur.cpp, line 474 > > <https://git.reviewboard.kde.org/r/126906/diff/1/?file=441789#file441789line474> > > > > Did you try the behavior on a varying scene? > > > > Generating mipmaps isn't exactly cheap and linear interpolation suffers > > from artifacts when things below move (I had tried an even smarter trick > > for general blurring, looks stunning and is incredibly fast ... as long as > > you deal with static contents) > > Martin Gräßlin wrote: > just tried a youtube video + the blur on my Ivybridge system. Didn't > notice any problems. That's of course not a scientific measurement ;-) > > Thomas Lübking wrote: > Harsh contrast changes would cause "flicker" - playing a video would > likely be more a CPU/GPU overhead (mipmapping) concern. > > Martin Gräßlin wrote: > in the given usage scenario (app dashboard) it's rather unlikely that > there are contrast changes. After all the set of windows below is supposed to > be kind of static.
I'm going to push it to master to expose it more testing. If we get complaints about bad effects, we can remove it again. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126906/#review91675 ----------------------------------------------------------- On Jan. 27, 2016, 2:24 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126906/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 2:24 p.m.) > > > Review request for kwin, Plasma and Eike Hein. > > > Repository: kwin > > > Description > ------- > > [kwineffects] Expose fullScreen property in EffectWindow > Also copied to Deleted. > > [effects] Add a simplified fullscreen blur > > If a window is fullscreen and wants fullscreen blur behind it, we > use the blur from logout effect. This is mostly intended for the > Application Dashboard which requires a fullscreen blur. The generic > blur effect is not designed for such usage and is rather costly. > > This simplified blur just needs framebuffer blit and midmaps. This > makes it rather cheap in usage and also doesn't need a cached texture. > > > Diffs > ----- > > deleted.h bb87ae9611a5b59a5b37cf5a4cd38e99ed987069 > deleted.cpp 239ba8fec76ad520728182faf6429be8730ebec1 > effects/blur/blur.h fd5a020688d0e4397ce18e03aa4f79565418e9c5 > effects/blur/blur.cpp a360f0301e2983d0fb0bf3effff71f95ac46ff22 > libkwineffects/kwineffects.h 4350e2b1c86252af43186164b10ad55fa388266e > libkwineffects/kwineffects.cpp b767f6671284295d2e81b023ef62b24fcca8929a > > Diff: https://git.reviewboard.kde.org/r/126906/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Dashboard with new algorithm. > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/27/b6607afa-cf10-4cd8-a490-7b56de4faaec__Spectacle.o12214.png > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
