----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126944/#review91849 -----------------------------------------------------------
+1 components/keyboardlayout/keyboardlayout.cpp (lines 85 - 87) <https://git.reviewboard.kde.org/r/126944/#comment62701> can be simplified to: QDBusPendingCall pendingDisplayName = mIface->asyncCallWithArgumentList(QStringLiteral("getLayoutDisplayName"), {mCurrentLayout}); components/keyboardlayout/keyboardlayout.cpp (line 92) <https://git.reviewboard.kde.org/r/126944/#comment62700> You can use a lambda - Kai Uwe Broulik On Feb. 1, 2016, 12:58 nachm., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126944/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 12:58 nachm.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Use display name (can be changed by user) instead of full layout name. > This matches the behavior of keyboard layout osd and systray. > > > Diffs > ----- > > components/keyboardlayout/keyboardlayout.h e5a172e > components/keyboardlayout/keyboardlayout.cpp 3e456ca > lookandfeel/contents/components/KeyboardLayoutButton.qml 0644f15 > > Diff: https://git.reviewboard.kde.org/r/126944/diff/ > > > Testing > ------- > > Changed the display name in kcm ("label" column), lockscreen displayed this > name. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel