> On 八月 9, 2016, 2:20 p.m., Sune Vuorela wrote: > > I think it was a bug that the individual barcode headers was public in the > > qt4 based prison. Now that we are about to release a qt5 based prison, it > > is time to fix that bug. > > > > Basically, I don't want the interface to change depending on what supposed > > backends prison is compiled with. > > > > createBarcode can be queried, and the result tested for null pointers if a > > specific feature is not compiled in. At runtime. So things can be > > enabled/disabled as needed without requiring changes in other parts of the > > code. > > > > It is a very deliberate action to not install the headers any more.
agree ;-) https://github.com/xiangzhai/qwx/commit/acb0b78cc0885a7234dc1ea4f8284ef96df35ae2 - Leslie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128633/#review98213 ----------------------------------------------------------- On 八月 9, 2016, 2:49 p.m., Leslie Zhai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128633/ > ----------------------------------------------------------- > > (Updated 八月 9, 2016, 2:49 p.m.) > > > Review request for Plasma and Sune Vuorela. > > > Repository: prison > > > Description > ------- > > Hi Sune, > > People might directly use Prison::QRCodeBarcode > https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.cpp#L9 instead of > via Prison::createBarcode > > so is it able to install the private header? > > Regards, > Leslie Zhai > > > Diffs > ----- > > lib/CMakeLists.txt 95391cc > > Diff: https://git.reviewboard.kde.org/r/128633/diff/ > > > Testing > ------- > > - prison/tests/test-prison > - plasma-workspace/klipper > - qwx/QRcodeQuick https://github.com/xiangzhai/qwx/blob/kf5/src/qrcodequick.h > > > Thanks, > > Leslie Zhai > >
