broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
TEST PLAN Wayland untested but compiled. (btw, serviceCache.contains and then serviceCache.value performs a double lookup, QHash value returns a default-constructed value for not found entries, so could probably be simplified to? KService::Ptr service = serviceCache.value(window); if (service) { // ... } REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2391 AFFECTED FILES libtaskmanager/abstracttasksmodel.cpp libtaskmanager/abstracttasksmodel.h libtaskmanager/abstracttasksmodeliface.h libtaskmanager/concatenatetasksproxymodel.cpp libtaskmanager/concatenatetasksproxymodel.h libtaskmanager/flattentaskgroupsproxymodel.cpp libtaskmanager/flattentaskgroupsproxymodel.h libtaskmanager/launchertasksmodel.cpp libtaskmanager/launchertasksmodel.h libtaskmanager/taskfilterproxymodel.cpp libtaskmanager/taskfilterproxymodel.h libtaskmanager/taskgroupingproxymodel.cpp libtaskmanager/taskgroupingproxymodel.h libtaskmanager/tasksmodel.cpp libtaskmanager/tasksmodel.h libtaskmanager/waylandtasksmodel.cpp libtaskmanager/waylandtasksmodel.h libtaskmanager/windowtasksmodel.cpp libtaskmanager/windowtasksmodel.h libtaskmanager/xwindowtasksmodel.cpp libtaskmanager/xwindowtasksmodel.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas