davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > NotificationItem.qml:33 > width: parent.width > - implicitHeight: Math.max(appIconItem.visible || imageItem.visible ? > units.iconSizes.large : 0, mainLayout.height) > + implicitHeight: Math.max(appIconItem.valid || imageItem.nativeWidth > 0 > ? units.iconSizes.large : 0, mainLayout.height) > If in https://phabricator.kde.org/D6215 you've got a mainItem->setVisible() before the showEvent because that fixes what this is doing. If that's the case, why do we still need these changes? > NotificationPopup.qml:60 > // notification.actions is a JS array, but we can easily append that > to our model > notificationItem.actions.clear() > notificationItem.actions.append(notificationProperties.actions) So instead of making this inhibitor and changing a bunch of code just convert: list.clear() list.append() into: list = otherList REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6216 To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
