mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed.
recycler should have a notify signal, because it's going to change all the time. the delegaterecycler instances are created/destroyed all the time like normal listview delegates, and the delegates instances, those that are actually recycled, will be assigned a new recycler when actually recycled. since is saved anyways as a context property, perhaps is better to just base off that one and taking care that's always kept up to date to the new recycler. INLINE COMMENTS > delegaterecycler.cpp:256 > + ctx->setContextProperty(QStringLiteral("index"), > m_propertiesTracker->property("trackedIndex")); > + ctx->setContextProperty(QStringLiteral("delegateRecycler"), this); > } tracking this property directly from qml will woirk as is the correct recycler, on the other hand the attached property won't, so is probably better to just have this one REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17592 To: apol, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein