Hi, On 04/10/2014 02:12 AM, Henrique de Moraes Holschuh wrote: > On Wed, 09 Apr 2014, Matthew Garrett wrote: >> On Wed, Apr 09, 2014 at 03:03:01PM -0300, Henrique de Moraes Holschuh wrote: >>> On Wed, 09 Apr 2014, Hans de Goede wrote: >>>> This patch seems to have fallen through the cracks, so here is a resend. >>> >>> Sort of. There was a doubt about one of the keycodes. >> >> I think I'm ok with the keycode. > > Ok. Now, provided that it doesn't clash with the other thinkpads (in which > case we'd just add selective keymaps), we can merge.
It does not clash with the new Carbon X1 2nd generation stuff, see: http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/platform/x86/thinkpad_acpi.c?id=8f5f86abc6593b6d600712435e2f24a7a098b951 Basically the new stuff uses hotkey codes >= TPACPI_HOTKEY_MAP_LEN, where as my patch adds mappings for codes < TPACPI_HOTKEY_MAP_LEN. (Where TPACPI_HOTKEY_MAP_LEN == 32) > Heck, we can fix that later too, it doesn't count as an ABI break, these > keymaps are _already_ configurable from userspace _and_ usually reconfigured > by userspace, the driver just tries to provide sane defaults. So... > > Acked-by: Henrique de Moraes Holschuh <h...@hmh.eng.br> Thanks & Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
