On Tue, Dec 08, 2015 at 03:19:17PM +0200, Andy Shevchenko wrote:
> On Mon, 2015-12-07 at 15:45 -0800, Darren Hart wrote:
> > On Tue, Dec 08, 2015 at 12:55:04AM +0800, Qipeng Zha wrote:
> > > BIOS restructure exported memory resources for Punit
> > > in acpi table, So update resources for Punit.
> > >
> > > Signed-off-by: Qipeng Zha <qipeng....@intel.com>
> >
> > Thank you for the update Qipeng. I will review shortly.
> >
> > +Andriy who originally raised the concern over the ACPI resource
> > assumptions in
> > the previous version. Andriy, this resource allocation looks to be a
> > substantial
> > improvement to me. Do you have any further concerns?
>
> So, regarding to the second patch
>
> 1. In excerpts like following
>
> if (IS_ERR(addr)) {
> dev_err(&pdev->dev, "Failed to map resouce for BIOS
> DATA\n");
> return PTR_ERR(addr);
> }
>
> No need to have an error message. Core already has something to print
> at that point.
>
>
> 2. No need to explicitly cast to / from void *.
>
> IPC_DEV *ipcdev = (IPC_DEV *)dev_id;
>
>
> Otherwise looks much better than very first version!
Good points, thanks Andriy.
Qipeng. I hate to ask for one more spin, but this is good feedback, and the
error messages from the previous note should be addressed. If you can give one
more update, we can get this queued to next and still make the 4.5 merge window.
Thanks for your efforts to get to this point. Nearly there!
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86"
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
