The patch attached fixes a CI failure as seen by gnome-software using
the new Gitlab instance. Tested on F27.
Richard.
From 80c7727aa7d963cee72cb392e4c911a720daae07 Mon Sep 17 00:00:00 2001
From: Richard Hughes <rich...@hughsie.com>
Date: Thu, 19 Oct 2017 13:43:22 +0100
Subject: [PATCH] Fix a critical warning on calling polkit_permission_new_sync
with no system bus
---
src/polkit/polkitpermission.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/polkit/polkitpermission.c b/src/polkit/polkitpermission.c
index f264094..d4b2459 100644
--- a/src/polkit/polkitpermission.c
+++ b/src/polkit/polkitpermission.c
@@ -137,10 +137,13 @@ polkit_permission_finalize (GObject *object)
g_free (permission->tmp_authz_id);
g_object_unref (permission->subject);
- g_signal_handlers_disconnect_by_func (permission->authority,
- on_authority_changed,
- permission);
- g_object_unref (permission->authority);
+ if (permission->authority != NULL)
+ {
+ g_signal_handlers_disconnect_by_func (permission->authority,
+ on_authority_changed,
+ permission);
+ g_object_unref (permission->authority);
+ }
if (G_OBJECT_CLASS (polkit_permission_parent_class)->finalize != NULL)
G_OBJECT_CLASS (polkit_permission_parent_class)->finalize (object);
--
2.14.2
_______________________________________________
polkit-devel mailing list
polkit-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/polkit-devel
