On Sat, Jan 07, 2012 at 08:59:13PM +0100, Landry Breuil wrote: > I don't have a printer either,but it seems to run fine here on amd64. > Some minor nits : > > > # These are actually internal modules, not generic shared libs > > -SHARED_LIBS= scribus12format 0.0 \ > > +SHARED_LIBS = scribus12format 0.0 \ > > scribus134format 0.0 \ > > scribus13format 0.0
Hi, thanks your review. I will try to do someting with that. > > Either those are internal plugins and they shouldnt be versionned, or > they should be bumped. Each shlib api need a major bump. > > > +# renaming scribus to scribus-ng not to conflict with stable version > > What does this mean here ? i don't see any scribus-ng, nor conflicts.. It seems to be forgotten from my old update which tried not to conflict with currently presented scribus version in the ports. > > You have a lot of gratuitous spacing changes in the Makefile which make > it hard to read/understand... other than that it looks good to me. I'll have a look. jirib
