quick re-post. Ob-patch for inotify option. Will merge.
On 09/15/10 05:53, Arjan van de Ven wrote:
>
>
> -------- Original Message --------
> Subject: Powertop: Change CONFIG_INOTIFY to CONFIG_INOTIFY_USER
> Date: Wed, 15 Sep 2010 10:22:39 +0200
> From: Jan Niehusmann
> To: ar...@linux.intel.com
>
>
>
> Hi Arjan,
>
> running powertop on 2.6.36-rc4, I noticed it suggests to enable
> CONFIG_INOTIFY, although I do have inotify support enabled.
>
> Reason is that the CONFIG_INOTIFY option was removed. What is still
> available is CONFIG_INOTIFY_USER, and I think that's what should be
> tested by powertop. CONFIG_INOTIFY_USER is available since 2.6.18.
>
> A trivial patch doing that change is appended below.
>
> Regards,
> Jan
>
> diff --git a/powertop.c b/powertop.c
> index 74eb328..8df3652 100644
> --- a/powertop.c
> +++ b/powertop.c
> @@ -1191,8 +1191,8 @@ int main(int argc, char **argv)
> suggest_kernel_config("CONFIG_CPU_FREQ_STAT", 1,
> _("Suggestion: Enable the
> CONFIG_CPU_FREQ_STAT kernel configuration option.\n"
> "This option allows PowerTOP to show
> P-state percentages \n" "P-states correspond to CPU frequencies."), 2);
> - suggest_kernel_config("CONFIG_INOTIFY", 1,
> - _("Suggestion: Enable the CONFIG_INOTIFY
> kernel configuration option.\n"
> + suggest_kernel_config("CONFIG_INOTIFY_USER", 1,
> + _("Suggestion: Enable the
> CONFIG_INOTIFY_USER kernel configuration option.\n"
> "This option allows programs to wait for
> changes in files and directories\n"
> "instead of having to poll for these
> changes"), 5);
>
>
_______________________________________________
Power mailing list
Power@bughost.org
http://www.bughost.org/mailman/listinfo/power
