not a problem! glad to contribute!

Cheers!
Durga



On Wed, Jul 16, 2014 at 1:31 PM, Murphy McCauley <murphy.mccau...@gmail.com>
wrote:

> Sure looks like a bug to me.  Thanks for the report; I've added it to the
> tracker on github.
>
> -- Murphy
>
>
> On Jul 15, 2014, at 8:25 PM, durga <c.vijaya.du...@gmail.com> wrote:
>
> Hi Murphy,
>
> Just a quick check.
>
> the def _parse_data(self,data) method of system_capabilities module always
> returns true. after a little checking,
>
> I think the module should be bitwise & :
>
>  def _parse_data (self, data):
>
>
>     (cap,en) = struct.unpack("!HH", data)
>
>
>     del self.caps[:]
>
>
>     del self.enabled_caps[:]
>
>
>     for i in range(0, 16):
>
>
>       self.caps.append(True if (cap *&* (1 << i)) else False)
>
>
>       self.enabled_caps.append(True if (en & (1 << i)) else False)
>
>
>
>
>
>
>
> currently its:
>
>   def _parse_data (self, data):
>
>
>     (cap,en) = struct.unpack("!HH", data)
>
>
>     del self.caps[:]
>
>
>     del self.enabled_caps[:]
>
>
>     for i in range(0, 16):
>
>
>       self.caps.append(True if (cap and (1 << i)) else False)
>
>
>       self.enabled_caps.append(True if (en and (1 << i)) else False)
>
>
>
> Cheers!
> Durga
>
>
>

Reply via email to