Update of patch #5661 (project pspp):
Status: Ready For Test/Review => Works For Me
Assigned to: blp => jmd
_______________________________________________________
Follow-up Comment #1:
Looks good.
I suspect that dict_unset_split_var should only call the callback if
d->split_cnt changes; otherwise, it will be called every time a variable is
deleted from the dictionary, regardless of whether the variable is actually a
split variable.
I agree that proc_cancel_temporary_transformations should ensure that the old
dictionary gets destroyed, but I think that actually dataset_set_dict should
be the one to do it. dataset_set_dict has only 3 existing callers, and all
of them destroy the old dictionary just before calling it, so this will drop
a line of code from each caller too.
>I'm posting this patch in case I've done anything evil in
src/data/dictionary.c or src/data/procedure.c
No worries.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?5661>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
pspp-dev mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/pspp-dev
