On Tue, Mar 19, 2013 at 04:55:37PM +0100, Alexander Dahl wrote: > Hei Michael, > > Am 2013-03-19 16:32, schrieb Michael Olbrich: > > On Thu, Mar 14, 2013 at 01:16:36PM +0100, Alexander Dahl wrote: > >> We use -Wcast-align on ARMv5 platform and libmodbus3 sets -Werror > >> which leads to a failing build in one case. This patch fixes the > >> alignment problem. Upstream pull requested. > > > > Hmm, this is just unit test stuff, right? We don't actually need this. > > Yes, I think so. The targetinstall rule does not install these binaries > anyway. > > > Maybe we should do this instead: > > > > LIBMODBUS3_MAKE_OPT := -C src > > LIBMODBUS3_INSTALL_OPT := -C src install > > My colleague removed 'tests' from Makefile.am, I don't know which one > would be the best choice.
I prefer to avoid patches when possible. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de
