On Wed, Apr 12, 2023 at 09:56:18AM +0200, Robin van der Gracht wrote: > On 12-04-2023 08:32, Michael Olbrich wrote: > > On Thu, Apr 06, 2023 at 04:50:16PM +0200, Robin van der Gracht wrote: > > > Signed-off-by: Robin van der Gracht <ro...@protonic.nl> > > > --- > > > rules/pcsc-lite.in | 5 +++++ > > > rules/pcsc-lite.make | 2 +- > > > 2 files changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/rules/pcsc-lite.in b/rules/pcsc-lite.in > > > index 016a70037..de1c288c3 100644 > > > --- a/rules/pcsc-lite.in > > > +++ b/rules/pcsc-lite.in > > > @@ -18,6 +18,11 @@ menuconfig PCSC_LITE > > > if PCSC_LITE > > > +config PCSC_LITE_USB > > > + bool "USB Support" > > > + help > > > + Add USB support. > > > > Wrong indention. This should be tabs instead of spaces. I've fixed this > > while applying the patch. In the future, please run 'ptxdist lint' before > > sending patches. It will complain about all the small stuff like this. > > > > Ack. Thanks for pointing out the lint feature. Will do.
Sorry, I dropped it. I looked at this again, and I don't think it needs an option. USB support by itself doesn't really do anything. From what I can tell, most of the code depends on either udev (we have an option for that) or libusb (that's disabled). So I think we can just enable USB unconditionally. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
