On 20/04/2023 23:37, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier <aderum...@odiso.com> > --- > ...-down-up-vxlan-interfaces-when-ifreload_down.patch | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git > a/debian/patches/pve/0005-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch > > b/debian/patches/pve/0005-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch > index c9964af..63494c9 100644 > --- > a/debian/patches/pve/0005-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch > +++ > b/debian/patches/pve/0005-ifreload-down-up-vxlan-interfaces-when-ifreload_down.patch > @@ -1,13 +1,16 @@ > From 2c38d0a157c8946f35a7da1c7c05484d33e6986f Mon Sep 17 00:00:00 2001 > From: Alexandre Derumier <aderum...@odiso.com> > Date: Wed, 5 Jun 2019 14:47:05 +0200 > -Subject: [PATCH 6/7] ifreload: down/up vxlan interfaces when > +Subject: [PATCH 6/7] ifreload: down/up vxlan && vlan interfaces when > ifreload_down_changed=0 > > almost all attributes of vxlan interfaces can't be updated > -in current kernel (<= 5.2). (including vxlan-id) > +(including vxlan-id). > > -so when ifreload_down_changed=0, ifreload can't update vxlan. > +Same for vlan interfaces (vlan-protocol, vlan-id) > + > +so when ifreload_down_changed=0, ifreload can't update vxlan or vlan > + attributes. > > fix: https://github.com/CumulusNetworks/ifupdown2/issues/50 > Signed-off-by: Alexandre Derumier <aderum...@odiso.com> > @@ -25,7 +28,7 @@ index b4e1864..9313573 100644 > > ifaceLinkKind.to_str(lastifaceobjlist[0].link_kind))) > ifacedownlist.append(newifaceobjlist[objidx].name) > - if not down_changed: > -+ if not down_changed and > ifaceLinkKind.to_str(lastifaceobjlist[0].link_kind) != 'vxlan': > ++ if not down_changed and > ifaceLinkKind.to_str(lastifaceobjlist[0].link_kind) != 'vxlan' and > ifaceLinkKind.to_str(lastifaceobjlist[0].link_kind) != 'vlan':
style nit: could be slightly nicer if we pull out the link_kind into an intermediate variable, i.e., something like: link_kind = ifaceLinkKind.to_str(lastifaceobjlist[0].link_kind) if not down_changed and link_kind != 'vxlan' and link_kind != 'vlan': > continue > if len(newifaceobjlist) != len(lastifaceobjlist): > ifacedownlist.append(ifname) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel