Am 16.04.24 um 17:02 schrieb Thomas Lamprecht: > Am 16/04/2024 um 15:18 schrieb Dominik Csapak: >> copies the OVF.pm and relevant ovf tests from qemu-server. >> We need it here, and it uses PVE::Storage already, and since there is no >> intermediary package/repository we could put it, it seems fitting in >> here. >> >> Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
Except for the location of the module: Reviewed-by: Fiona Ebner <f.eb...@proxmox.com> > > high-level nit: this, and most of the ESXi one, should go into another module > name space, e.g. PVE::GuestImport:: (or if that's to long, or we really are > sure > that other stuff can be imported (I doubt it), then just PVE::Import might be > fine too). > Hmm, ESXiPlugin.pm is a storage plugin, so it does fit. But no objections to moving it from my side either. And fully agree that OVF.pm should live somewhere else, it is not a storage plugin. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel