Am 15.04.24 um 10:26 schrieb Lukas Wagner: > This allows users to create notification match rules for specific > replication jobs, if they so desire. > > Signed-off-by: Lukas Wagner <l.wag...@proxmox.com> > --- > PVE/API2/Replication.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm > index 0dc944c9..703640f5 100644 > --- a/PVE/API2/Replication.pm > +++ b/PVE/API2/Replication.pm > @@ -140,8 +140,8 @@ my sub _handle_job_err { > }; > > my $metadata_fields = { > - # TODO: Add job-id? > type => "replication", > + "replication-job" => $job->{id}, > }; > > eval {
Not sure if we should use "replication-job" and "backup-job" for the metadata entries rather then just "job-id". The type is already something that can be matched, why re-do it implicitly with the field name? E.g. I want to see all jobs with -fiona- on the system, now I'd have to create a matcher rule for each job type. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel