if the hardware/driver is capable, the admin can now mark a pci device
as 'live-migration-capable', which then tries enabling live migration
for such devices.

mark it as experimental when configuring and in the migrate window

Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
---
 www/manager6/window/Migrate.js    | 25 ++++++++++++++++++++-----
 www/manager6/window/PCIMapEdit.js | 12 ++++++++++++
 2 files changed, 32 insertions(+), 5 deletions(-)

diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index c553a1ee..272ab022 100644
--- a/www/manager6/window/Migrate.js
+++ b/www/manager6/window/Migrate.js
@@ -244,10 +244,10 @@ Ext.define('PVE.window.Migrate', {
            }
 
            let blockingResources = [];
-           let mappedResources = migrateStats['mapped-resources'] ?? [];
+           let mappedResources = migrateStats['mapped-resource-info'] ?? {};
 
            for (const res of migrateStats.local_resources) {
-               if (mappedResources.indexOf(res) === -1) {
+               if (!mappedResources[res]) {
                    blockingResources.push(res);
                }
            }
@@ -271,14 +271,29 @@ Ext.define('PVE.window.Migrate', {
                }
            }
 
-           if (mappedResources && mappedResources.length) {
-               if (vm.get('running')) {
+           if (mappedResources && vm.get('running')) {
+               let allowed = [];
+               let notAllowed = [];
+               for (const [key, resource] of Object.entries(mappedResources)) {
+                   if (resource['live-migration']) {
+                       allowed.push(key);
+                   } else {
+                       notAllowed.push(key);
+                   }
+               }
+               if (notAllowed.length > 0) {
                    migration.possible = false;
                    migration.preconditions.push({
                        text: Ext.String.format('Can\'t migrate running VM with 
mapped resources: {0}',
-                       mappedResources.join(', ')),
+                       notAllowed.join(', ')),
                        severity: 'error',
                    });
+               } else if (allowed.length > 0) {
+                   migration.preconditions.push({
+                       text: Ext.String.format('Live-migrating running VM with 
mapped resources (Experimental): {0}',
+                       allowed.join(', ')),
+                       severity: 'warning',
+                   });
                }
            }
 
diff --git a/www/manager6/window/PCIMapEdit.js 
b/www/manager6/window/PCIMapEdit.js
index d43f04eb..731269a0 100644
--- a/www/manager6/window/PCIMapEdit.js
+++ b/www/manager6/window/PCIMapEdit.js
@@ -242,6 +242,18 @@ Ext.define('PVE.window.PCIMapEditWindow', {
                        disabled: '{hideComment}',
                    },
                },
+               {
+                   xtype: 'proxmoxcheckbox',
+                   fieldLabel: gettext('Live Migration Capable'),
+                   labelWidth: 200,
+                   boxLabel: `<i class="fa fa-exclamation-triangle 
warning"></i> ${gettext('Experimental')}`,
+                   reference: 'live-migration-capable',
+                   name: 'live-migration-capable',
+                   cbind: {
+                       deleteEmpty: '{!isCreate}',
+                       disabled: '{hideComment}',
+                   },
+               },
            ],
 
            columnB: [
-- 
2.39.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to