On 2024-04-19 10:45, Fiona Ebner wrote: > Nit: I always like a quick sentence for who needs it for such changes. > > Am 09.04.24 um 15:25 schrieb Lukas Wagner: >> Signed-off-by: Lukas Wagner <l.wag...@proxmox.com> >> --- >> proxmox-notify/src/lib.rs | 10 +++++++--- >> 1 file changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/proxmox-notify/src/lib.rs b/proxmox-notify/src/lib.rs >> index 91c0b61..8d4dc63 100644 >> --- a/proxmox-notify/src/lib.rs >> +++ b/proxmox-notify/src/lib.rs >> @@ -159,11 +159,13 @@ pub trait Endpoint { >> fn disabled(&self) -> bool; >> } >> >> -#[derive(Debug, Clone)] >> +#[derive(Debug, Clone, Serialize, Deserialize)] >> +#[serde(rename_all = "kebab-case")] >> pub enum Content { >> /// Title and body will be rendered as a template >> Template { >> /// Name of the used template >> + #[serde(rename = "template-name")] > > So I guess this is here, because the rename_all above is not recursive? > Should we put rename_all on top of Template and ForwardedMail (if that > even works), so we are sure not to forget it for potential future fields? > Yup, rename_all is not recursive. Added a rename_all for Template and ForwardedMail, this makes more sense. Thanks! -- - Lukas _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
- [pve-devel] [PATCH proxmox-perl-rs 14/19] notify: adapt to Op... Lukas Wagner
- [pve-devel] [PATCH proxmox-perl-rs 13/19] notify: don't pass ... Lukas Wagner
- [pve-devel] [PATCH manager 18/19] tests: remove vzdump_notifi... Lukas Wagner
- [pve-devel] [PATCH proxmox 02/19] notify: make api methods ta... Lukas Wagner
- [pve-devel] [PATCH proxmox 06/19] notify: give each notificat... Lukas Wagner
- [pve-devel] [PATCH proxmox 10/19] notify: pbs context: includ... Lukas Wagner
- [pve-devel] [PATCH proxmox 09/19] notify: derive Deserialize/... Lukas Wagner
- Re: [pve-devel] [PATCH proxmox 09/19] notify: derive Des... Fiona Ebner
- Re: [pve-devel] [PATCH proxmox 09/19] notify: derive... Lukas Wagner
- [pve-devel] [PATCH proxmox-perl-rs 12/19] notify: use file ba... Lukas Wagner
- [pve-devel] [PATCH proxmox 04/19] notify: don't make tests re... Lukas Wagner
- [pve-devel] [PATCH proxmox 03/19] notify: convert Option<V... Lukas Wagner
- [pve-devel] [PATCH proxmox 08/19] notify: derive `api` for De... Lukas Wagner
- [pve-devel] [PATCH proxmox 01/19] notify: switch to file-base... Lukas Wagner
- Re: [pve-devel] [PATCH proxmox 01/19] notify: switch to ... Fiona Ebner
- Re: [pve-devel] [PATCH proxmox 01/19] notify: switch... Lukas Wagner
- Re: [pve-devel] [PATCH proxmox 01/19] notify: sw... Fiona Ebner
- Re: [pve-devel] [PATCH proxmox 01/19] notify... Lukas Wagner
- [pve-devel] [PATCH proxmox 05/19] notify: make the `mail-forw... Lukas Wagner