Jim Gallacher
Tue, 31 Jan 2006 05:49:32 -0800
If that is the case I wonder if we should roll in the changes to support apache 2.2. I scanned mod_python for deprecated or removed apr calls and can find only one (apr_sockaddr_port_get), plus the missing APR_STATUS_IS_SUCCESS macro.
The original macro is:
#define APR_STATUS_IS_SUCCESS(s) ((s) == APR_SUCCESS \
|| (s) == APR_OS_START_SYSERR + NO_ERROR)
The discussion on httpd-dev suggested that this macro should be
substituted with a simple test such as "if (rc != APR_SUCCESS)", and the
'||' condition was not likely used. So that we are making the fewest
possible changes to our current 3.2 codebase, I'd suggest reimplenting
APR_STATUS_IS_SUCCESS in our code, and then removing it 3.3. This will
give us lot's of time as we work on 3.3 to discover if there are any
problems droping the APR_OS_START_SYSERR part of the test.
Jim