----- Le 6 Mai 24, à 6:16, Thomas Huth th...@redhat.com a écrit :
> On 05/05/2024 16.05, Inès Varhol wrote:
>> For USART, GPIO and SYSCFG devices, check that clock frequency before
>> and after enabling the peripheral clock in RCC is correct.
>>
>> Signed-off-by: Inès Varhol <ines.var...@telecom-paris.fr>
>> ---
>> Hello,
>>
>> Should these tests be regrouped in stm32l4x5_rcc-test.c ?
>
> Hi,
>
> sounds mostly like a matter of taste at a first glance. Or what would be the
> benefit of putting everything into the *rcc-test.c file? Could you maybe
> consolidate the get_clock_freq_hz() function that way? (maybe that
> get_clock_freq_hz() function could also be consolidated as a inline function
> in a shared header instead?)
>
> Thomas
Hello,
I was indeed looking to consolidate the functions get_clock_freq_hz() and
check_clock() from *usart-test.c (along with the definitions for RCC
registers).
Thank you for your suggestion, I'll use a header file.
Inès Varhol
